Note the metadata convention for generated binaries - #20
Merged
Conversation
Tool-generated files carry an embedded record of the machine that produced them. The report PDF under docs/reports, for instance, still names the HTML file it was rendered from, the browser engine and version, the operating system, and the minute it was made — none of it visible in the document, all of it in a public repository. Nothing sensitive in that particular file, so it stays as it is. Writing the convention down so the next generated artifact gets stripped before it lands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tool-generated files carry an embedded record of the machine that produced
them. The report PDF under
docs/reports, for instance, still names the HTMLfile it was rendered from (
honest-report.html), the rendering engine andversion (
Skia/PDF m149,HeadlessChrome), the operating system(
Windows NT 10.0; Win64; x64), and the minute it was generated. None of it isvisible in the document; all of it is in a public repository.
Nothing sensitive in that particular file, and rewriting a published artifact
over benign metadata is not worth it — so it stays as it is. This just writes
the convention down so the next generated artifact gets stripped before it
lands.